feat: Home button clear search query #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #916 +/- ##
==========================================
+ Coverage 25.58% 30.76% +5.18%
==========================================
Files 47 60 +13
Lines 5628 4456 -1172
==========================================
- Hits 1440 1371 -69
+ Misses 3989 2863 -1126
- Partials 199 222 +23 ☔ View full report in Codecov by Sentry. |
fmartingr
requested changes
May 25, 2024
There was a problem hiding this comment.
I don't particularly like instancing a new Vue app to have only the $bus methods available, but since we have Vue outdated and we would need to take a look at this further in the future probably requiring a more in-depth refactor, this looks good to me now, and I like the use of events.
I've just left a comment because I think the event listener should be in a different place.
|
Hi |
fmartingr
reviewed
May 26, 2024
fmartingr
requested changes
May 26, 2024
truecharts-admin
referenced
this pull request
in truecharts/public
Jun 8, 2024
…0@85a47b2 by renovate (#23111) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/go-shiori/shiori](https://togithub.com/go-shiori/shiori) | minor | `v1.6.3` -> `v1.7.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>go-shiori/shiori (ghcr.io/go-shiori/shiori)</summary> ### [`v1.7.0`](https://togithub.com/go-shiori/shiori/releases/tag/v1.7.0) [Compare Source](https://togithub.com/go-shiori/shiori/compare/v1.6.3...v1.7.0) **Always remember to backup your data before updating.** #### Notable changes ##### System Theme ([@​Monirzadeh](https://togithub.com/Monirzadeh)) [#​924](https://togithub.com/go-shiori/shiori/issues/924) Shiori now allows you to change the theme to light/dark or follow the system configuration.  ##### New migrations backend ([@​fmartingr](https://togithub.com/fmartingr)) [#​876](https://togithub.com/go-shiori/shiori/issues/876) The underlying migrations system has been rewritten to custom code removing the [go-migrate dependency](https://togithub.com/golang-migrate/migrate). This not only removes one more dependency but also allows for more control over the migrations process by letting us add run code in a migration, for example, to update the database schema. This should be transparent for all users but if you find any problems please [report it](https://togithub.com/go-shiori/shiori/issues/new/choose) ##### OpenBSD support ([@​pacoesteban](https://togithub.com/pacoesteban)) [#​780](https://togithub.com/go-shiori/shiori/issues/780) This has been in the works for several months since we broke it around 1.5 but thanks to the above migration changes and some custom database engine backend for OpenBSD, we are now able to support OpenBSD again. We added a CI step to get early warnings if we introduce something that breaks support. #### What's Changed - feat: new migration system by [@​fmartingr](https://togithub.com/fmartingr) in [https://github.com/go-shiori/shiori/pull/876](https://togithub.com/go-shiori/shiori/pull/876) - chore(deps): bump the all group across 1 directory with 4 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-shiori/shiori/pull/895](https://togithub.com/go-shiori/shiori/pull/895) - refactor: allow specific sqlite engine for OpenBSD by [@​pacoesteban](https://togithub.com/pacoesteban) in [https://github.com/go-shiori/shiori/pull/780](https://togithub.com/go-shiori/shiori/pull/780) - chore(deps): bump the all group across 1 directory with 4 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-shiori/shiori/pull/900](https://togithub.com/go-shiori/shiori/pull/900) - chore(deps): bump the all group with 4 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-shiori/shiori/pull/902](https://togithub.com/go-shiori/shiori/pull/902) - fix: not checking for nil-pointer errors on migrations by [@​fmartingr](https://togithub.com/fmartingr) in [https://github.com/go-shiori/shiori/pull/906](https://togithub.com/go-shiori/shiori/pull/906) - ci: unify local and ci docker workflows by [@​fmartingr](https://togithub.com/fmartingr) in [https://github.com/go-shiori/shiori/pull/907](https://togithub.com/go-shiori/shiori/pull/907) - fix: ensure tmp folder is present on docker container by [@​fmartingr](https://togithub.com/fmartingr) in [https://github.com/go-shiori/shiori/pull/910](https://togithub.com/go-shiori/shiori/pull/910) - deps: update golang dependencies by [@​fmartingr](https://togithub.com/fmartingr) in [https://github.com/go-shiori/shiori/pull/915](https://togithub.com/go-shiori/shiori/pull/915) - chore(deps): bump the all group with 3 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-shiori/shiori/pull/908](https://togithub.com/go-shiori/shiori/pull/908) - chore(deps): bump the all group with 2 updates by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-shiori/shiori/pull/917](https://togithub.com/go-shiori/shiori/pull/917) - feat: Home button clear search query by [@​Monirzadeh](https://togithub.com/Monirzadeh) in [https://github.com/go-shiori/shiori/pull/916](https://togithub.com/go-shiori/shiori/pull/916) - chore(deps): bump codecov/codecov-action from 4.4.0 to 4.4.1 in the all group by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-shiori/shiori/pull/922](https://togithub.com/go-shiori/shiori/pull/922) - chore: check for avx2 processor feature when trying to run bun by [@​Monirzadeh](https://togithub.com/Monirzadeh) in [https://github.com/go-shiori/shiori/pull/920](https://togithub.com/go-shiori/shiori/pull/920) - ci: fix codecov action by [@​fmartingr](https://togithub.com/fmartingr) in [https://github.com/go-shiori/shiori/pull/928](https://togithub.com/go-shiori/shiori/pull/928) - fix: incorrect original link in archive page by [@​fmartingr](https://togithub.com/fmartingr) in [https://github.com/go-shiori/shiori/pull/931](https://togithub.com/go-shiori/shiori/pull/931) - fix : wrong response type for readable endpoint documentation by [@​Monirzadeh](https://togithub.com/Monirzadeh) in [https://github.com/go-shiori/shiori/pull/932](https://togithub.com/go-shiori/shiori/pull/932) - feat: allow selecting light/dark/follow themes in the webui by [@​Monirzadeh](https://togithub.com/Monirzadeh) in [https://github.com/go-shiori/shiori/pull/924](https://togithub.com/go-shiori/shiori/pull/924) - fix: add version to goreleaser archive filename by [@​fmartingr](https://togithub.com/fmartingr) in [https://github.com/go-shiori/shiori/pull/934](https://togithub.com/go-shiori/shiori/pull/934) #### New Contributors - [@​pacoesteban](https://togithub.com/pacoesteban) made their first contribution in [https://github.com/go-shiori/shiori/pull/780](https://togithub.com/go-shiori/shiori/pull/780) **Full Changelog**: go-shiori/shiori@v1.6.3...v1.7.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTkuMyIsInVwZGF0ZWRJblZlciI6IjM3LjM5OS4zIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
click on Home will clear search field and load home in initiate state
close #914
Related discussion #871