Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new system info panel in webui settings #926

Merged
merged 12 commits into from
Jun 8, 2024

Conversation

fmartingr
Copy link
Member

  • Adds a new /api/v1/system/info API call with some general system settings (only allowed by owner accounts)
  • Adds a new panel into the webui settings to display the information
  • Updates swagger spec
  • Fix: Minus symbol not being correctly swapped in webui settings detail panes
  • Fix: Swagger definition incorrect in bookmark endpoint
  • Fix: Incorrect return value for Database.DBx

Screenshots

Screenshot 2024-06-03 at 11 06 41

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.

Project coverage is 34.66%. Comparing base (650f192) to head (f855d22).

Files Patch % Lines
internal/testutil/http.go 80.00% 3 Missing ⚠️
internal/http/routes/api/v1/api.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
+ Coverage   34.08%   34.66%   +0.58%     
==========================================
  Files          60       61       +1     
  Lines        4008     4050      +42     
==========================================
+ Hits         1366     1404      +38     
- Misses       2420     2424       +4     
  Partials      222      222              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmartingr fmartingr requested a review from Monirzadeh June 8, 2024 06:44
@fmartingr fmartingr added this to the 1.8.0 milestone Jun 8, 2024
Copy link
Collaborator

@Monirzadeh Monirzadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work.
you done some part that i like to do and make things easier (special thanks for fake admin)
i left some comment that point to a specific bug.

Copy link
Collaborator

@Monirzadeh Monirzadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@fmartingr fmartingr merged commit 72aecd2 into master Jun 8, 2024
14 checks passed
@fmartingr fmartingr deleted the feat/webui-system-info branch June 8, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants