Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always show bookmark menu on tablets #944

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

fmartingr
Copy link
Member

Changes the max-width for the bookmark menu to show, always displaying it on mobile and tablet devices (and potentially lower resolution desktop/laptops).

@fmartingr fmartingr self-assigned this Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.66%. Comparing base (bc8c06a) to head (d78e5ab).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #944   +/-   ##
=======================================
  Coverage   34.66%   34.66%           
=======================================
  Files          61       61           
  Lines        4050     4050           
=======================================
  Hits         1404     1404           
  Misses       2424     2424           
  Partials      222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Monirzadeh Monirzadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fmartingr fmartingr merged commit 06efb08 into master Jun 26, 2024
14 checks passed
@fmartingr fmartingr deleted the fix/bookmark-menu-tablets branch June 26, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants