Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better style for quotes #951

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Conversation

Monirzadeh
Copy link
Collaborator

@Monirzadeh Monirzadeh commented Jul 3, 2024

This PR add better style for quotes in readable version.
close #950

@romu70 @fmartingr any suggestion for better style? specifically in this design use Red is not too much eye caching for a quote. we can change design completely different.

Preview
qoute

@Monirzadeh Monirzadeh requested a review from fmartingr July 3, 2024 11:40
@romu70
Copy link

romu70 commented Jul 3, 2024

My take

Screenshot 2024-07-03 at 13 54 22

@romu70
Copy link

romu70 commented Jul 3, 2024

Fixed.

We can also think about having a soft color background instead of the gray, or having a color accent.

@fmartingr
Copy link
Member

I would use something simple, a box with a bit darker/lighter background depending on the theme, the text in italics and probably nothing else, to match the simplicity of the rest of the themes.

Once we start working on custom css users could customize this to their needs.

@Monirzadeh
Copy link
Collaborator Author

@fmartingr any other change?

dark
light

@fmartingr
Copy link
Member

fmartingr commented Jul 4, 2024

@fmartingr any other change?

Honestly I would be much more simple than that, I don't like extra distractions on transformations on the readable version.

Screenshot 2024-07-04 at 08 24 51

blockquote {
	padding: 15px;
	margin: 15px;
	font-style: italic;
	background: var(--bgqoute);
}

Also I would put this style under the #content section, so it only applies to the readable version.

@Monirzadeh
Copy link
Collaborator Author

Monirzadeh commented Jul 6, 2024

done
it is better to separate other page like content page CSS to a separate file too like archive.less

Copy link
Member

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fmartingr fmartingr merged commit 9a113af into go-shiori:master Aug 27, 2024
9 checks passed
@Monirzadeh Monirzadeh deleted the better-quotes branch August 27, 2024 17:39
@Monirzadeh Monirzadeh self-assigned this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quotes are not well rendered in archives
3 participants