Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Flashes won't clear when using store other than default CookieStore #1913

Closed
lufinima opened this issue Feb 27, 2020 · 1 comment
Closed
Assignees
Milestone

Comments

@lufinima
Copy link

lufinima commented Feb 27, 2020

I've already seen older issues about this case when using Redis backed store #911 and supposedly it has been fixed with PR #1141 but it seem's there is an reversion because the bug is still around.
The fix in the PR if applied to current code seem's to fix the issue.
If the code

defer c.Flash().persist(c.Session())

line in the route_info.go is removed and added after route_info.go as

c.Flash().persist(c.Session())

, without the

defer

it works.
I've tested this fix with

FilesystemStore

and with a custom

SQLiteStore
@paganotoni paganotoni self-assigned this Oct 22, 2020
@paganotoni paganotoni added this to the v0.16.16 milestone Oct 22, 2020
@paganotoni
Copy link
Member

This one is solved by v0.16.16

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants