Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

make DefaultContext private #2247

Open
sio4 opened this issue Apr 21, 2022 · 0 comments
Open

make DefaultContext private #2247

sio4 opened this issue Apr 21, 2022 · 0 comments
Assignees
Labels
breaking change This feature / fix introduces breaking changes enhancement New feature or request
Milestone

Comments

@sio4
Copy link
Member

sio4 commented Apr 21, 2022

DefaultContext implements buffalo.Context and this is the core context for buffalo's application flow, and it should be configured correctly to work properly with its functions. However, DefaultContext is currently public, so it can be used without careful configuration by initializing it directly. It could be better to make it private and just provide a generator function. (currently, App.newContext() is the generator)

TODO

  • make DefaultContext private and only allow it to be generated by App.newContext() or other internal code.

Context

@sio4 sio4 added enhancement New feature or request breaking change This feature / fix introduces breaking changes labels Apr 21, 2022
@sio4 sio4 added this to the v1.0.0 milestone Apr 21, 2022
@sio4 sio4 self-assigned this Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This feature / fix introduces breaking changes enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant