NOTE: the reason of forking this repository

[sio4]

This repository was forked from https://github.com/shurcooL/github_flavored_markdown in late 2018 to fix the dependency issue.
Currently, there is no significant functional fragmentation so far and it could be fine to keep it as is.

The related PRs are:

• removed the weird blackfriday dep buffalo#1216
  • https://github.com/gobuffalo/buffalo/pull/1216/files#diff-ac069b752eca30067e98020f2707cd0f30063fe516596330ce41a384ad62f340
• switch to gobuffalo/github_flavored_markdown plush#68

[sio4]

I would like to deprecate this fork if the issue was gone, not now but when we have enough bandwidth to work on this issue.

Currently, it has the following vendorized modules:

• https://github.com/shurcooL/github_flavored_markdown the original module
• https://github.com/shurcooL/highlight_diff
• https://github.com/shurcooL/highlight_go
• https://github.com/shurcooL/octicon
• https://github.com/shurcooL/sanitized_anchor_name
• https://github.com/russross/blackfriday

[paganotoni]

@sio4 This is probably related to the topic in this issue: I've been wanting to remove the auto-loading of the helpers in the plush package because these include this dependency. That would imply loading these helpers in Buffalo. Would you happen to have any thoughts on this change?

https://github.com/gobuffalo/plush/blob/main/helpers.go#L22

[sio4]

Do you mean you want to Buffalo core not to depends on GFM at least by default? (I am not sure if I understand you correctly due to my poor English. Oh, it's not getting well as much as I wish)

Since we support markdown natively for template rendering, I think dependency on GFM is necessary even though I don't know how many users use md for templates.

Did I understand your comment correctly? Please explain me if I missed your meaning.

https://gobuffalo.io/documentation/frontend-layer/rendering/#markdown