Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: consolidate the default middlewares into a single module #1

Closed
10 tasks done
sio4 opened this issue Feb 11, 2023 · 2 comments
Closed
10 tasks done

process: consolidate the default middlewares into a single module #1

sio4 opened this issue Feb 11, 2023 · 2 comments
Assignees
Labels
process process or management stuffs
Milestone

Comments

@sio4
Copy link
Member

sio4 commented Feb 11, 2023

As of today, we have 7 official middleware modules and 4 of them are used in a new app by default. Now, these middleware are stable and have no much update recently except dependency updates. To reduce the maintenance effort on these modules, and also to simplify the module dependency structure, I would like to consolidate the default middleware (which are mw-csrf, mw-forcessl, mw-i18n, and mw-paramlogger) into a single module. Each of them will be a separate package in the module but will share the same module version and other stuff.

The process will be:

  • prepare the new module by merging them all together into this repository
  • update and clean up all the old modules before deprecating them, and releasing them as the last versions.
  • improve the CLI to use the new module for a new app
  • improve the CLI fixer to update existing apps, but this is optional
  • --> CLI v0.18.14 was released with this update

Hey @paganotoni, as we discussed before, I am going to deprecate the old default middleware modules (4 modules) and merge them into this module. Please take a look at the rough process above and let me know if you have any concern or comment on it. ETA for this work is the end of this month roughly.

Related tasks:

@sio4 sio4 added the process process or management stuffs label Feb 11, 2023
@sio4 sio4 added this to the v1.0.0 milestone Feb 11, 2023
@sio4 sio4 self-assigned this Feb 11, 2023
@paganotoni
Copy link
Member

I'm glad you brought this one up, and I appreciate what you're doing here. This will make our codebase way simpler.

@sio4
Copy link
Member Author

sio4 commented Feb 16, 2023

Completed!

@sio4 sio4 closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process process or management stuffs
Projects
None yet
Development

No branches or pull requests

2 participants