Changes from gocardless-dotnet-template #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandilya-narahari
force-pushed
the
template-changes
branch
from
6f23b09 to
200eff5
Compare
olivictor
reviewed
Nov 2, 2020
| /// An array of fields which are missing and is required to set up the | ||
| /// mandate. | ||
| /// </summary> | ||
| public class PayerAuthorisationIncompleteField |
There was a problem hiding this comment.
Why is this in singular? I guess it just messed with the summary - maybe because the description is empty
There was a problem hiding this comment.
I think singular is fine here as its plural in where it's used:
public List<PayerAuthorisationIncompleteField> IncompleteFields { get; set; }
olivictor
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
LGTM, but would like to have someone from @gocardless/mme-experience to take a look too before merging. Maybe @lancscoder who's got more experience with .NET?
This is our new API dedicated to building custom payment pages. It encapsulates the creation of customer, bank account and mandate under this single resource.
sandilya-narahari
force-pushed
the
template-changes
branch
from
298ee5b to
fb4da36
Compare
lancscoder
approved these changes
Nov 4, 2020
| /// An array of fields which are missing and is required to set up the | ||
| /// mandate. | ||
| /// </summary> | ||
| public class PayerAuthorisationIncompleteField |
There was a problem hiding this comment.
I think singular is fine here as its plural in where it's used:
public List<PayerAuthorisationIncompleteField> IncompleteFields { get; set; }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating client libraries as part of PayerAuthorisation API launch