Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game window not closing correctly if you have a dialog open #102460

Closed
Giganzo opened this issue Feb 5, 2025 · 5 comments · Fixed by #102470
Closed

Game window not closing correctly if you have a dialog open #102460

Giganzo opened this issue Feb 5, 2025 · 5 comments · Fixed by #102470

Comments

@Giganzo
Copy link
Contributor

Giganzo commented Feb 5, 2025

Tested versions

Godot v4.4.beta (c394eaa)

System information

Fedora Linux 40 (KDE Plasma) on Wayland - X11 display driver, Multi-window

Issue description

If you have a dialog open and press the X to close the game window. The game window will not close and instead move independent of the game view.

Screencast_20250205_143149.webm

Steps to reproduce

^

Minimal reproduction project (MRP)

window-close.zip

@matheusmdx
Copy link
Contributor

Seems a regression between 4.4 beta 1 and 4.4 beta 2, i'll bisect.

@akien-mga
Copy link
Member

This might be the same issue as #102239.

@Hilderin
Copy link
Contributor

Hilderin commented Feb 5, 2025

That is caused by the fact that since beta 2, the game is closed via a command sent to the game using the debugger. In beta 1, the X was killing the game process.

The embedded window probably never moves when a dialog is opened and you move the floating window, even without clicking the X.

@Giganzo
Copy link
Contributor Author

Giganzo commented Feb 5, 2025

The embedded window probably never moves when a dialog is opened and you move the floating window, even without clicking the X.

It moves with the window

Screencast_20250205_143638.webm

@matheusmdx
Copy link
Contributor

matheusmdx commented Feb 5, 2025

Bisected to #101895, @Hilderin

Image


I revert pr #101895 and tested #102239 and the bug related in #102239 persists so seems to not be the same case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Very Bad
Development

Successfully merging a pull request may close this issue.

5 participants