Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: protoc-gen-gogofast not generate trailing comments #764

Open
hitzhangjie opened this issue Feb 22, 2023 · 0 comments · May be fixed by #765
Open

BUG: protoc-gen-gogofast not generate trailing comments #764

hitzhangjie opened this issue Feb 22, 2023 · 0 comments · May be fixed by #765

Comments

@hitzhangjie
Copy link

hitzhangjie commented Feb 22, 2023 •
edited
Loading

for example, here's the protobuf:

syntax="proto3";
package hello;
...
message HelloRequest {
    // xxx111
    string msg = 1; // xxx222
}

Then execute the: protoc --gogofast_out=. hello.proto, the generated code is:

type HelloRequest struct {
    // xxx111
    Msg                  string   `protobuf:"bytes,1,opt,name=msg,proto3" json:"msg,omitempty"`                                                                        
    XXX_NoUnkeyedLiteral struct{} `json:"-"`
    XXX_unrecognized     []byte   `json:"-"`
    XXX_sizecache        int32    `json:"-"`
}

We could see, the trailing comments is not generated, while protoc-gen-go will handle both the leading and trailing comments. Please support this style of trailing comments.

This style of trailing comments will help align the fields, much clearer. It will improve readability. I won't have to switch between the *.pb.go and *.proto file.
@hitzhangjie hitzhangjie changed the title protoc-gen-gogofast not generate trailing comments BUG: protoc-gen-gogofast not generate trailing comments Feb 22, 2023
hitzhangjie added a commit to hitzhangjie/protobuf that referenced this issue Feb 22, 2023
@hitzhangjie
feat: generates trailing comments of message field
68cd8f8 
close gogo#764
hitzhangjie added a commit to hitzhangjie/protobuf that referenced this issue Feb 22, 2023
@hitzhangjie
feat: generates trailing comments of message field
d295500 
close gogo#764
@hitzhangjie hitzhangjie linked a pull request Feb 22, 2023 that will close this issue
Open
hitzhangjie added a commit to hitzhangjie/protobuf that referenced this issue Feb 22, 2023
@hitzhangjie
feat: generates trailing comments of message field
5fae409 
close gogo#764
hitzhangjie added a commit to hitzhangjie/protobuf that referenced this issue Feb 22, 2023
@hitzhangjie
feat: generates trailing comments of message field
3213114 
close gogo#764
hitzhangjie added a commit to hitzhangjie/protobuf that referenced this issue Feb 22, 2023
@hitzhangjie
feat: generates trailing comments of message field
2b9f383 
close gogo#764
hitzhangjie added a commit to hitzhangjie/protobuf that referenced this issue Feb 22, 2023
@hitzhangjie
feat: generates trailing comments of message field
f29354e 
close gogo#764
hitzhangjie added a commit to hitzhangjie/protobuf that referenced this issue Feb 22, 2023
@hitzhangjie
feat: generates trailing comments of message field
f4d7380 
close gogo#764
hitzhangjie added a commit to hitzhangjie/protobuf that referenced this issue Feb 23, 2023
@hitzhangjie
feat: generates trailing comments of message field
a38f6f9 
close gogo#764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: generates trailing comments of message field hitzhangjie/protobuf
1 participant
@hitzhangjie