Skip to content

Commit

Permalink
commands: Add -O flag to server to open browser
Browse files Browse the repository at this point in the history
Fixes #13040
  • Loading branch information
bep committed Nov 14, 2024
1 parent 23d21b0 commit ac6962d
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions commands/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import (
"time"

"github.com/bep/mclib"
"github.com/pkg/browser"

"github.com/bep/debounce"
"github.com/bep/simplecobra"
Expand Down Expand Up @@ -448,6 +449,7 @@ type serverCommand struct {
// Flags.
renderStaticToDisk bool
navigateToChanged bool
openBrowser bool
serverAppend bool
serverInterface string
tlsCertFile string
Expand Down Expand Up @@ -539,6 +541,7 @@ of a second, you will be able to save and see your changes nearly instantly.`
cmd.Flags().BoolVarP(&c.serverAppend, "appendPort", "", true, "append port to baseURL")
cmd.Flags().BoolVar(&c.disableLiveReload, "disableLiveReload", false, "watch without enabling live browser reload on rebuild")
cmd.Flags().BoolVarP(&c.navigateToChanged, "navigateToChanged", "N", false, "navigate to changed content file on live browser reload")
cmd.Flags().BoolVarP(&c.openBrowser, "openBrowser", "O", false, "open the site in a browser after server startup")
cmd.Flags().BoolVar(&c.renderStaticToDisk, "renderStaticToDisk", false, "serve static files from disk and dynamic files from memory")
cmd.Flags().BoolVar(&c.disableFastRender, "disableFastRender", false, "enables full re-renders on changes")
cmd.Flags().BoolVar(&c.disableBrowserError, "disableBrowserError", false, "do not show build errors in the browser")
Expand Down Expand Up @@ -998,6 +1001,13 @@ func (c *serverCommand) serve() error {

c.r.Println("Press Ctrl+C to stop")

if c.openBrowser {
// There may be more than one baseURL in multihost mode, open the first.
if err := browser.OpenURL(baseURLs[0].String()); err != nil {
c.r.logger.Warnf("Failed to open browser: %s", err)
}
}

err = func() error {
for {
select {
Expand Down

0 comments on commit ac6962d

Please sign in to comment.