Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the deploy feature out into its own release archives #12994

Closed
bep opened this issue Oct 29, 2024 · 4 comments
Closed

Move the deploy feature out into its own release archives #12994

bep opened this issue Oct 29, 2024 · 4 comments
Assignees
Milestone

Comments

@bep
Copy link
Member

bep commented Oct 29, 2024

I have received a question/report about some questionable network activity from Hugo on Windows. This is from a more complex setup that is not practical for me to set up, but I have inspected the code and my prime suspect is the hugo deploy command (the Microsoft Azure integration), which does static initialisation, even if you don't use the feature. We really need to make this feature some kind of plugin (e.g. Wasm), but until then I suggest we pull it out into separate release archives.

We already have a nodeploy build tag for this, so that should not be too hard.

@bep bep added the Bug label Oct 29, 2024
@bep bep added this to the v0.137.0 milestone Oct 29, 2024
@bep bep self-assigned this Oct 29, 2024
@jmooring
Copy link
Member

Does that mean we need to do something like this?

Edition name File name
standard hugo_0.136.5_linux-amd64.tar.gz
extended hugo_extended_0.136.5_linux-amd64.tar.gz
standard/deploy hugo_with_deploy_0.136.5_linux-amd64.tar.gz
extended/deploy hugo_extended_with_deploy_0.136.5_linux-amd64.tar.gz

@bep
Copy link
Member Author

bep commented Oct 29, 2024

Does that mean we need to do something like this?

I thought about making it a little bit simpler and only create deploy variants for the extended images, so something ala:

Edition name File name
standard hugo_0.136.5_linux-amd64.tar.gz
extended hugo_extended_0.136.5_linux-amd64.tar.gz
extended/deploy hugo_extended_with_deploy_0.136.5_linux-amd64.tar.gz

@jmooring
Copy link
Member

That looks good to me.

bep added a commit that referenced this issue Oct 30, 2024
Build tags setup changed to:

* !nodeploy => withdeploy
* nodeploy => !withdeploy

Also move the deploy feature out into its own release archives.

Fixes #12994
bep added a commit that referenced this issue Oct 30, 2024
Build tags setup changed to:

* !nodeploy => withdeploy
* nodeploy => !withdeploy

Also move the deploy feature out into its own release archives.

See #12994 for the primary motivation for this change. But this also greatly reduces the number of dependencies in Hugo when you don't need this feature and cuts the binary size greatly.

Fixes #12994
bep added a commit that referenced this issue Oct 30, 2024
Build tags setup changed to:

* !nodeploy => withdeploy
* nodeploy => !withdeploy

Also move the deploy feature out into its own release archives.

See #12994 for the primary motivation for this change. But this also greatly reduces the number of dependencies in Hugo when you don't need this feature and cuts the binary size greatly.

Fixes #12994
bep added a commit that referenced this issue Oct 30, 2024
Build tags setup changed to:

* !nodeploy => withdeploy
* nodeploy => !withdeploy

Also move the deploy feature out into its own release archives.

See #12994 for the primary motivation for this change. But this also greatly reduces the number of dependencies in Hugo when you don't need this feature and cuts the binary size greatly.

Fixes #12994
bep added a commit that referenced this issue Oct 30, 2024
Build tags setup changed to:

* !nodeploy => withdeploy
* nodeploy => !withdeploy

Also move the deploy feature out into its own release archives.

See #12994 for the primary motivation for this change. But this also greatly reduces the number of dependencies in Hugo when you don't need this feature and cuts the binary size greatly.

Fixes #12994
@bep bep modified the milestones: v0.137.0, v0.138.0 Oct 30, 2024
@bep bep closed this as completed in 89bd025 Oct 30, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants