Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: document what the Go project wants from code review #22002

Closed
ianlancetaylor opened this issue Sep 24, 2017 · 2 comments
Closed

project: document what the Go project wants from code review #22002

ianlancetaylor opened this issue Sep 24, 2017 · 2 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@ianlancetaylor
Copy link
Member

Pulled out of #21956 comment by @andybons at #21956 (comment) .

  • Draft a feature comparison between Gerrit and GitHub with input from golang-dev@ as to what features are keeping the project off of GitHub for Code Review.
  • Present a proposal that addresses the concerns raised by the members of the development team where you explain how these issues will be solved either by presenting a (very) convincing argument that they don’t really matter, or proposing changes to existing tooling. Concrete data also helps you in this case. Rallying for GitHub to implement features is also not out of the question.
  • Outline who will do the work and what the timeline is. If it’s the Go team at Google, explaining why it’s more important than the many other things on our plate is part of the process.

Other actions not related to moving to GitHub:

  • File bugs to improve documentation in cases where you feel it’s confusing or lacking.
  • If you can, submit patches to make the documentation or tooling better.
@ianlancetaylor ianlancetaylor added help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 24, 2017
@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Sep 24, 2017
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Sep 24, 2017
@martisch
Copy link
Contributor

I think isolation of actions with permissions is also good to address in requirements documentation of the review/submit management system.
e.g. currently being able to gardening/triaging issues on github does not also grant submit/+2 rights automatically (currently in Gerrit) and being able to e.g. close issues should i think ideally not allowing to delete a branch in the source of truth repository.

@ianlancetaylor
Copy link
Member Author

Now that we have https://github.com/golang/go/wiki/GerritBot, this issue doesn't seem particularly interesting. Closing it out.

@golang golang locked and limited conversation to collaborators Nov 21, 2019
@golang golang unlocked this conversation Jul 10, 2023
@golang golang locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants