Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gerritbot: support multiple CL authors (Co-authored-by) #40906

Open
hyangah opened this issue Aug 19, 2020 · 0 comments
Open

x/build/cmd/gerritbot: support multiple CL authors (Co-authored-by) #40906

hyangah opened this issue Aug 19, 2020 · 0 comments
Labels
Builders x/build issues (builders, bots, dashboards) Community FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Aug 19, 2020

The current gerrit and gerritbot workflow is designed assuming a single author for a CL.
But we observed that often that is not always the case, and see features or changes that
involve multiple authors.

  1. a PR is from the results of pair or group programming.
  2. the original PR author couldn't continue for some reason so the maintainers or someone else have to finish it before merging.

Currently, gerritbot picks the last committer as the author if a PR involves multiple authors.
(See #38957)

Correctly checking CLA of all involved authors, and attributing contribution to
everyone is important for open source projects.

I don't know if Gerrit supports multi-author workflows.
Github has support for multiple authors using Co-authored-by trailers.
https://github.blog/2018-01-29-commit-together-with-co-authors/
Even when Gerrit wouldn't provide the support, I hope the gerritbot still can ensure
CLA check to be run on all the authors (I think it already does) and include all the
committers (except those merged during rebase?) with the Co-authored-by trailers
before squashing.

cc @dmitshur @golang/osp-team

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 19, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 19, 2020
@dmitshur dmitshur added FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Community labels Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) Community FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants