-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/go/ssa: unexpected container type in IndexExpr #52834
Comments
I am not yet able to reproduce from the given instructions. Also the stack looks like it is for deepgo. Maybe email me reproducer instructions and I can minimize from there? |
From builder.go:
This is ignoring when e.X is a *go/ast.SelectorExpr. Looking into a fix. |
Change https://go.dev/cl/405555 mentions this issue: |
go get -u golang.org/x/tools go mod tidy x/tools/go/ssa is used by message/pipeline. The version 0.1.11 required contained an issue related to generics, when generics instantiation was confused with container index. However, x/tools/go/ssa does have it fixed at head (see golang/go#52834). This change upgrades the required version to ensure less users of message/pipelines have issues. For golang/go#54086
Change https://go.dev/cl/422414 mentions this issue: |
go get -u golang.org/x/tools go mod tidy x/tools/go/ssa is used by message/pipeline. Generics instantiation in x/[email protected] could be confused with container index. However, x/tools/go/ssa does have it fixed in x/[email protected] (see golang/go#52834). This change upgrades the required version to ensure that fewer users of message/pipelines have issues. Updates golang/go#54086
go get -u golang.org/x/tools go mod tidy x/tools/go/ssa is used by message/pipeline. Generics instantiation in x/[email protected] could be confused with container index. However, x/tools/go/ssa does have it fixed in x/[email protected] (see golang/go#52834). This change upgrades the required version to ensure that fewer users of message/pipelines have issues. Updates golang/go#54086
go get -u golang.org/x/tools go mod tidy x/tools/go/ssa is used by message/pipeline. Generics instantiation in x/[email protected] could be confused with container index. However, x/tools/go/ssa does have it fixed in x/[email protected] (see golang/go#52834). This change upgrades the required version to ensure that fewer users of message/pipelines have issues. Updates golang/go#54086 Change-Id: I03882a7bb2c75a8f16ef376d06f2cf714d39e7a2 GitHub-Last-Rev: 351404b GitHub-Pull-Request: #32 Reviewed-on: https://go-review.googlesource.com/c/text/+/422414 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Tim King <[email protected]> Reviewed-by: Tim King <[email protected]> Reviewed-by: Peter Weinberger <[email protected]>
go get -u golang.org/x/tools go mod tidy x/tools/go/ssa is used by message/pipeline. Generics instantiation in x/[email protected] could be confused with container index. However, x/tools/go/ssa does have it fixed in x/[email protected] (see golang/go#52834). This change upgrades the required version to ensure that fewer users of message/pipelines have issues. Updates golang/go#54086 Change-Id: I03882a7bb2c75a8f16ef376d06f2cf714d39e7a2 GitHub-Last-Rev: 351404b GitHub-Pull-Request: golang#32 Reviewed-on: https://go-review.googlesource.com/c/text/+/422414 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Tim King <[email protected]> Reviewed-by: Tim King <[email protected]> Reviewed-by: Peter Weinberger <[email protected]>
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
The hash commit of the x/tools version is ddadc42. It should also reproduce with the newest version of tools.
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Load
./...
packages of https://github.com/cri-o/cri-o.git using x/tools/ssa withBuilderMode(0)
.What did you expect to see?
Successful building with no failures and crashes.
What did you see instead?
The text was updated successfully, but these errors were encountered: