Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: Gerrit comment content should be posted to GitHub PRs #59159

Closed
willfaught opened this issue Mar 20, 2023 · 2 comments
Closed

x/build/cmd/gerritbot: Gerrit comment content should be posted to GitHub PRs #59159

willfaught opened this issue Mar 20, 2023 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@willfaught
Copy link
Contributor

I get emails all the time like this from GopherBot posts on Go GitHub PRs:

Message from Bryan Mills:

Patch Set 2: Code-Review+1

(5 comments)

(5 comments) isn't very useful. Is it possible to at least include the comment content in the GitHub post, if not make a PR code comment for each Gerrit code comment?
@gopherbot gopherbot added this to the Proposal milestone Mar 20, 2023
@ianlancetaylor
Copy link
Contributor

No reason for this to be a proposal, so taking it out of the proposal process.

CC @golang/release

@ianlancetaylor ianlancetaylor changed the title proposal: x/build/cmd/gopherbot: Gerrit comment content should be posted to GitHub PRs x/build/cmd/gopherbot: Gerrit comment content should be posted to GitHub PRs Mar 20, 2023
@ianlancetaylor ianlancetaylor added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed Proposal labels Mar 20, 2023
@ianlancetaylor ianlancetaylor modified the milestones: Proposal, Unreleased Mar 20, 2023
@dmitshur dmitshur changed the title x/build/cmd/gopherbot: Gerrit comment content should be posted to GitHub PRs x/build/cmd/gerritbot: Gerrit comment content should be posted to GitHub PRs Mar 21, 2023
@dmitshur
Copy link
Contributor

This is #38689.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2023
@golang golang locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@willfaught @dmitshur @ianlancetaylor @gopherbot