-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: memory corruption on darwin/amd64 #60449
Comments
Found new dashboard test flakes for:
2023-05-22 17:56 darwin-amd64-12_0 exp@2e198f4a go@f0e356a0 (log) |
Runtime heap corruption in |
We should probably aggregate such issues into a single issue. |
This failure mode looks substantially different from the other Darwin cluster described in #54461 (comment) (which includes #59995). That cluster of failures is characterized by a goroutine stuck copying a pipe connected to a dead child process: either So I think this issue is probably independent of #59995. |
Agreed. I changed my mind after posting the last message and looking at the other failures again, but then I had a meeting. :P |
I was going back through issues assigned to me (oops, I have a backlog) and I noticed that #58715 is also memory corruption, but none of those failures include forkExec. Just mentioning it here since it might be related. |
found pointer to free object
on darwin/amd64
#55167 (comment) looks like plausibly the same kind of corruption; updated the |
Found new dashboard test flakes for:
2023-06-16 20:47 darwin-amd64-10_15 go@0183c1aa cmd/go.TestScript (log)
|
found pointer to free object
on darwin/amd64
Found new dashboard test flakes for:
2023-07-24 17:08 darwin-amd64-12_0 tools@67ba5997 go@df0a1297 x/tools/go/packages.TestAll (log)
|
Found new dashboard test flakes for:
2023-06-23 21:36 darwin-amd64-10_15 telemetry@5a4cd7a1 go@bca81759 (log)
|
Found new dashboard test flakes for:
2023-07-27 16:59 darwin-amd64-12_0 tools@bacac149 go@77863e42 x/tools/gopls/test.TestStringChanges (log)
|
Found new dashboard test flakes for:
2023-08-21 23:20 darwin-amd64-11_0 go@e3c80f57 cmd/go.TestScript (log)
2023-08-22 08:38 darwin-amd64-longtest go@05f95115 runtime.TestEINTR (log)
|
Found new dashboard test flakes for:
2024-01-08 18:46 darwin-amd64-12_0 build@21e06540 go@59ecebf4 (log) |
I wonder if this might be due to an uninitialized pointer field in a syscall result. That could explain the bad pointers, at least, but I guess it doesn't explain the other failure modes. |
@golang/runtime, should this be marked as a release-blocker for Go 1.22? |
Found new dashboard test flakes for:
2023-12-11 23:10 darwin-amd64-nocgo tools@f40889dc go@f4ff0e25 x/tools/go/analysis/passes/deepequalerrors (log)
|
I may be misunderstanding the policy, but I think technically it's not a release-blocker since we released Go 1.21 with the same issue, so it's not new to this release. (The fact that we released Go 1.21 without figuring out what it is is on it's own something that we should maybe revisit, but I think that's where we are today.) I don't want to be the sole judge on this so I'll add it to the next weekly meeting and/or revisit this in triage. @cherrymui spent a good bit of time investigating this and had a lot of difficulty reproducing. (Mentioning that here because I don't think that was recorded in this issue.) The crash rate is also fairly low, so it's difficult to continue to prioritize this against other things that need fixing, especially since the amount of time this bug could take to resolve is unknown and likely high. Again, not trying to make a decision, just trying to rationalize how we got here. The other aspect to this is that it doesn't seem to have impacted downstream users much, if at all. It's possible that users are just ignoring it, but IIRC other Darwin issues that appeared on the builders have been reported in the past, such as the CPU profile related one. This makes me wonder if maybe it's our postsubmit Mac machines specifically that are the problem. It also occurs to me that I haven't seen the same kinds of failures on the LUCI infrastructure. Those builders have been up long enough that I would've expected to see at least one such failure by now. They have a few failures from other unique sources, but I haven't seen anything like this yet. I will say that it's possible the failure got missed on the LUCI builders because |
Previously, the Obviously we don't have much control over the ventilation of Amazon's EC2 Mac Minis, though. It's unfortunate that so few Macs support ECC memory. 😒 |
Found new dashboard test flakes for:
2024-01-18 23:21 darwin-amd64-13 build@911ff433 go@2540b143 (log) |
On the main repo, main branch, watchflakes doesn't find any failure matching this for most recent builds in 45 days. I could run it for longer time period and see. Update: also no match on LUCI builders in a longer period of time. |
Found new dashboard test flakes for:
2024-01-22 20:52 darwin-amd64-11_0 tools@e2ca5942 go@a95136a8 x/tools/go/analysis/passes/stdmethods.TestAnalyzeEncodingXML (log)
|
Found new dashboard test flakes for:
2024-02-06 21:16 darwin-amd64-12_0 tools@0d875898 go@f2920803 x/tools/gopls/internal/test/integration/misc.TestRunGovulncheckStd (log)
|
Found new dashboard test flakes for:
2024-02-13 14:38 darwin-amd64-11_0 tools@1b39a8b6 go@1b541502 x/tools/go/packages (log)
|
Found new dashboard test flakes for:
2024-03-27 17:55 darwin-amd64-nocgo go@979b34b3 cmd/compile/internal/ssa [build] (log)
|
Found new dashboard test flakes for:
2024-05-02 22:38 darwin-amd64-11_0 tools@ccdef3cc go@93d8777d x/tools/gopls/internal/test/integration/completion (log)
|
Found new dashboard test flakes for:
2024-05-09 15:16 darwin-amd64-11_0 tools@24f3b32f go@dd6dee48 x/tools/go/packages (log)
|
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: