Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonpb: decode int32/uint32/float32/float64 strings #630

Merged
merged 1 commit into from
Jun 22, 2018
Merged

jsonpb: decode int32/uint32/float32/float64 strings #630

merged 1 commit into from
Jun 22, 2018

Conversation

kassiansun
Copy link
Contributor

According to
https://developers.google.com/protocol-buffers/docs/proto3#json,
all integers & floats are accepted as strings.

We still preserve the encoding behavior, to parse int64s to strings and other number to number.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@kassiansun kassiansun changed the title Decodes int32/uint32/float32/float64 strings Decodes int32/uint32/float32/float64 strings in jsonpb Jun 8, 2018
@kassiansun
Copy link
Contributor Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@dsnet dsnet changed the title Decodes int32/uint32/float32/float64 strings in jsonpb jsonpb: decode int32/uint32/float32/float64 strings Jun 9, 2018
@kassiansun
Copy link
Contributor Author

Anyone'd like to take a look at this?

@dsnet
Copy link
Member

dsnet commented Jun 22, 2018

Looks good. Thank you.

@dsnet dsnet merged commit 9eb2c01 into golang:master Jun 22, 2018
@golang golang locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants