go/analysis/passes/printf: return Result for querying func Kind #138

aaronbee · 2019-07-15T23:59:40Z

printf.Result has IsPrint function telling the caller if a function is
a Print/Printf function or a wrapper of one.

This aids in developing Ananlyzer's applying checks on Print/Printf
functions.

Implements @alandonovan suggestion from
golang/go#29616 (comment)

googlebot · 2019-07-15T23:59:43Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

aaronbee · 2019-07-16T00:00:54Z

I signed it!

googlebot · 2019-07-16T00:01:06Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

aaronbee · 2019-07-16T00:03:12Z

I attempted to write a test for this, but was hampered by the existing test file being in the printf_test package instead of printf. I didn't see a way to write a test without access to the printf package internals. Open to suggestions.

gopherbot · 2019-07-16T00:04:08Z

This PR (HEAD: 5e5351b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/186317 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-07-16T00:05:47Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/186317.
After addressing review feedback, remember to publish your drafts!

go/analysis/passes/printf/printf.go

gopherbot · 2019-07-16T02:58:22Z

This PR (HEAD: 8b4d493) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/186317 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-07-16T03:10:22Z

This PR (HEAD: 12af032) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/186317 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

go/analysis/passes/printf/printf.go

gopherbot · 2019-07-17T00:01:35Z

This PR (HEAD: 4586288) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/186317 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-07-17T02:32:50Z

Message from Alan Donovan:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/186317.
After addressing review feedback, remember to publish your drafts!

aaronbee · 2019-08-31T20:34:41Z

I had to resolve some conflicts with the changes to support fmt.Errorf.

gopherbot · 2019-08-31T20:34:47Z

This PR (HEAD: 2b7dfe4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/186317 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-08-31T20:37:31Z

This PR (HEAD: 2961237) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/186317 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-09-03T14:46:28Z

Message from Alan Donovan:

Patch Set 7: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/186317.
After addressing review feedback, remember to publish your drafts!

@alandonovan

printf.Result allows clients to learn if a function is a Print/Printf function or a wrapper of one. This aids in developing Ananlyzer's applying checks on Print/Printf functions. Implements @alandonovan suggestion from golang/go#29616 (comment) Change-Id: I57833d5c65c417f2e4a761d9187fc133937f39fb

gopherbot · 2019-09-03T18:11:52Z

This PR (HEAD: 5cb9115) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/186317 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-09-09T20:19:53Z

Message from Aaron Beitch:

Patch Set 8:

Bump. I added another patchset to add a missing case in the String() method.

Please don’t reply on this GitHub thread. Visit golang.org/cl/186317.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-10T20:24:37Z

Message from Michael Matloob:

Patch Set 8: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/186317.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-20T17:32:11Z

Message from Aaron Beitch:

Patch Set 8:

Patch Set 8: Code-Review+2

Thanks for the review. Anything more I need to do to get his merged?

Please don’t reply on this GitHub thread. Visit golang.org/cl/186317.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-09-20T17:32:12Z

Message from Aaron Beitch:

Patch Set 8:

Patch Set 8:

Patch Set 8: Code-Review+2

Thanks for the review. Anything more I need to do to get his merged?

this*

Please don’t reply on this GitHub thread. Visit golang.org/cl/186317.
After addressing review feedback, remember to publish your drafts!

@alandonovan

printf.Result has IsPrint function telling the caller if a function is a Print/Printf function or a wrapper of one. This aids in developing Ananlyzer's applying checks on Print/Printf functions. Implements @alandonovan suggestion from golang/go#29616 (comment) Change-Id: I203d51f1fcab7d8574d9309c22b404f8e3de43db GitHub-Last-Rev: 5cb9115 GitHub-Pull-Request: #138 Reviewed-on: https://go-review.googlesource.com/c/tools/+/186317 Reviewed-by: Michael Matloob <[email protected]>

gopherbot · 2019-10-28T16:17:20Z

This PR is being closed because golang.org/cl/186317 has been merged.

googlebot added the cla: no label Jul 15, 2019

googlebot added cla: yes and removed cla: no labels Jul 16, 2019

alandonovan reviewed Jul 16, 2019

View reviewed changes

aaronbee force-pushed the printf_result branch from 5e5351b to 8b4d493 Compare July 16, 2019 02:57

aaronbee force-pushed the printf_result branch from 8b4d493 to 12af032 Compare July 16, 2019 03:09

aaronbee changed the title ~~go/analysis/passes/printf: return Result with IsPrint helper~~ go/analysis/passes/printf: return Result for querying func Kind Jul 16, 2019

alandonovan approved these changes Jul 16, 2019

View reviewed changes

go/analysis/passes/printf/printf.go Outdated Show resolved Hide resolved

go/analysis/passes/printf/printf.go Outdated Show resolved Hide resolved

go/analysis/passes/printf/printf.go Outdated Show resolved Hide resolved

aaronbee force-pushed the printf_result branch from 12af032 to 4586288 Compare July 17, 2019 00:00

aaronbee force-pushed the printf_result branch from 4586288 to 2b7dfe4 Compare August 31, 2019 20:33

aaronbee force-pushed the printf_result branch from 2b7dfe4 to 2961237 Compare August 31, 2019 20:36

aaronbee force-pushed the printf_result branch from 2961237 to 5cb9115 Compare September 3, 2019 18:11

gopherbot force-pushed the master branch from b0a6c2a to 22c3443 Compare September 12, 2019 15:29

gopherbot force-pushed the master branch from 9cd7e18 to b917058 Compare October 4, 2019 02:21

gopherbot closed this Oct 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

go/analysis/passes/printf: return Result for querying func Kind #138

go/analysis/passes/printf: return Result for querying func Kind #138

aaronbee commented Jul 15, 2019

googlebot commented Jul 15, 2019

aaronbee commented Jul 16, 2019

googlebot commented Jul 16, 2019

aaronbee commented Jul 16, 2019

gopherbot commented Jul 16, 2019

gopherbot commented Jul 16, 2019

gopherbot commented Jul 16, 2019

gopherbot commented Jul 16, 2019

gopherbot commented Jul 17, 2019

gopherbot commented Jul 17, 2019

aaronbee commented Aug 31, 2019

gopherbot commented Aug 31, 2019

gopherbot commented Aug 31, 2019

gopherbot commented Sep 3, 2019

gopherbot commented Sep 3, 2019

gopherbot commented Sep 9, 2019

gopherbot commented Sep 10, 2019

gopherbot commented Sep 20, 2019

gopherbot commented Sep 20, 2019

gopherbot commented Oct 28, 2019

go/analysis/passes/printf: return Result for querying func Kind #138

go/analysis/passes/printf: return Result for querying func Kind #138

Conversation

aaronbee commented Jul 15, 2019

googlebot commented Jul 15, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

aaronbee commented Jul 16, 2019

googlebot commented Jul 16, 2019

aaronbee commented Jul 16, 2019

gopherbot commented Jul 16, 2019

gopherbot commented Jul 16, 2019

gopherbot commented Jul 16, 2019

gopherbot commented Jul 16, 2019

gopherbot commented Jul 17, 2019

gopherbot commented Jul 17, 2019

aaronbee commented Aug 31, 2019

gopherbot commented Aug 31, 2019

gopherbot commented Aug 31, 2019

gopherbot commented Sep 3, 2019

gopherbot commented Sep 3, 2019

gopherbot commented Sep 9, 2019

gopherbot commented Sep 10, 2019

gopherbot commented Sep 20, 2019

gopherbot commented Sep 20, 2019

gopherbot commented Oct 28, 2019