Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stringintconv and ifaceassert to govet #1360

Merged
merged 2 commits into from
Feb 20, 2021
Merged

Add stringintconv and ifaceassert to govet #1360

merged 2 commits into from
Feb 20, 2021

Conversation

SVilgelm
Copy link
Member

@SVilgelm SVilgelm commented Sep 8, 2020 •
edited by ldez
Loading

Add new linters:

  • stringintconv, enabled by default
  • ifaceassert is additional linter

Move govet tests to a dedicated folder

Fix #1359

@SVilgelm SVilgelm marked this pull request as draft September 8, 2020 19:45
@SVilgelm
Copy link
Member Author

SVilgelm commented Sep 8, 2020

@bombsimon Something wrong here, it had to fail here: https://github.com/golangci/golangci-lint/pull/1360/files#diff-fec92a1aa6b31bf39c48b7934581c028R13

converted to draft

@bombsimon
Copy link
Member

@bombsimon Something wrong here, it had to fail here: https://github.com/golangci/golangci-lint/pull/1360/files#diff-fec92a1aa6b31bf39c48b7934581c028R13

converted to draft

Oh, I was too quick. Will do a new review when converted to PR again!

@ldez ldez added the linter: new Support new linter label Dec 27, 2020
@ldez
Copy link
Member

ldez commented Feb 18, 2021 •
edited
Loading

@SVilgelm could you allow me to continue your PR?

FYI it's not possible to put the tests inside a dedicated folder because the tests are never run by make test_linters.

@ldez
Copy link
Member

ldez commented Feb 20, 2021 •
edited
Loading

@SVilgelm friendly ping

FYI I already prepared a fix.

Sergey Vilgelm and others added 2 commits February 20, 2021 16:03
@ldez
Add stringintconv and ifaceassert to govet
f479a92 
Add new linters:
* stringintconv, enabled by default
* ifaceassert is additional linter

Move govet tests to a dedicated folder
@ldez
fix: tests
d3ec33e
@ldez
Copy link
Member

ldez commented Feb 20, 2021

FYI I don't really want to open a new PR because you have already done 99,999% of the job.

As this PR has been open for 6 months, I suppose that you don't have time to spend on that PR.

I take your silence as a "yes" and I will rebase and fix the PR.

@ldez ldez marked this pull request as ready for review February 20, 2021 15:14
@SVilgelm
Copy link
Member Author

Sorry, I actually have no enough time and already forgot about this PR :)
Feel free to use it

@SVilgelm
Copy link
Member Author

SVilgelm commented Feb 20, 2021 •
edited by ldez
Loading

@ldez you can merge it anytime

ldez
ldez approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit f00da2c into master Feb 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-1359 branch February 20, 2021 15:37
ashanbrown pushed a commit to ashanbrown/golangci-lint that referenced this pull request Feb 20, 2021
@ashanbrown
Add stringintconv and ifaceassert to govet (golangci#1360)
7dce1ff
This was referenced Mar 7, 2021
Closed
Open
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
This was referenced Mar 12, 2021
Closed
Closed
Merged
Closed
@ldez ldez added this to the v1.38 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
linter: new Support new linter
Projects
None yet
Milestone
v1.38
Development

Successfully merging this pull request may close these issues.

Missing warning for string(x)
3 participants
@SVilgelm @bombsimon @ldez