-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docs and Assets Github Actions #1460
Update Docs and Assets Github Actions #1460
Conversation
Hey, thank you for opening your first Pull Request ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, I have one comment below. Another point to think about is pre-release and post-release, currently, I think it's ok to do all the step in post-release.
@neha-viswanathan first glance looks good, will do proper review later. I have added team for another 👀 as well. |
@neha-viswanathan correct me if I am wrong, based on your screen shot, the PR got created, but I can't find it in your forked repo. Can you share the link here ? |
@sayboras I test this on a dummy tag I created on my fork - https://github.com/neha-viswanathan/golangci-lint/tree/v100 |
Seems like you are making some changes, please share link to auto-generated PR in your forked repo as part of your testing. |
@sayboras This is the link to the actions - i'm unable to run |
As this one never runs in github action before, I am not sure what the reason could be. The best you can do is to replicate it locally by cross checking npm/node/etc version in github action. This target is working fine for me. If you don't have time or can't figure it out, feel free to skip this |
The permissions are good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ldez let's merge it and release a new version
Hey, @neha-viswanathan — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
@ldez it's failed, I think that the @golangci-releaser user should be a member of the @golangci/team, according to the documentation https://docs.github.com/en/rest/reference/teams#members @jirfag @ernado Could you please add the https://github.com/golangci-releaser user to the team? |
Closes #1208