-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix go-header usage #1785
Fix go-header usage #1785
Conversation
There's a known behavior of YAML template blocks using `|` that they insert a trailing newline. To remove it add `-` a.k.a block chomping indicator.
Hey, thank you for opening your first Pull Request ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you
Hey, @syndbg — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
There's a known behavior of YAML template blocks using
|
that they insert a trailing newline.To remove it add
-
a.k.a block chomping indicator.This would address some of the "weird" copyright header linting offenses that happen by following the example golangci-lint config by heart.