Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

private linter support for autofix #2565

Closed
ashanbrown opened this issue Feb 13, 2022 · 3 comments
Closed

private linter support for autofix #2565

ashanbrown opened this issue Feb 13, 2022 · 3 comments
Labels
duplicate This issue or pull request already exists linter: custom About custom/private linters

Comments

@ashanbrown
Copy link
Contributor

ashanbrown commented Feb 13, 2022 •
edited
Loading

Your feature request related to a problem? Please describe.

Private linters can't enable autofix

Describe the solution you'd like.

A way to set autofix, and really all config settings for a custom linter. A custom linter is also currently assumed to be fast and to need typo info. Is there any reason we can't expose these controls in the custom linter setting?

Describe alternatives you've considered.

Running my custom linter outside of golangci lint.

Additional context.

See the code for where we set up custom linters.
@ashanbrown ashanbrown added the enhancement New feature or improvement label Feb 13, 2022
@ldez ldez added the linter: custom About custom/private linters label Feb 13, 2022
@ldez
Copy link
Member

ldez commented Feb 13, 2022

Related to #1779

@ashanbrown
Copy link
Contributor Author

I didn't realize that we weren't ready to apply SuggestedFixes. LMK if I can help.

@ldez
Copy link
Member

ldez commented Jun 4, 2023

duplicate of #1728

@ldez ldez closed this as completed Jun 4, 2023
@ldez ldez added duplicate This issue or pull request already exists and removed enhancement New feature or improvement labels Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists linter: custom About custom/private linters
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashanbrown @ldez