vg/vggio: first import of a Gio-backed canvas #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
done. |
|
the lint failure (unable to inspect a dependency that uses not sure what to do at this point. |
kortschak
previously approved these changes
Jun 19, 2020
3 tasks
|
The golangci-lint failure is irritating. I will file an issue to them about that later. |
|
I think I understand this failure; the GitHub action that runs golangci-lint does not have the Cgo dependencies installed (the travis build does, but it's independent). You will need to have pre-install step in a .golangci.yml file that installs those deps, see https://github.com/gonum/gonum/blob/master/.github/workflows/golangci-lint.yml and then adding something like |
kortschak
approved these changes
Jun 19, 2020
|
nice catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #627.