Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop msgpack dependency, go full msgspec #313

Closed
2 tasks done
goodboy opened this issue Jul 11, 2022 · 0 comments · Fixed by #317
Closed
2 tasks done

Drop msgpack dependency, go full msgspec #313

goodboy opened this issue Jul 11, 2022 · 0 comments · Fixed by #317
Labels
IPC and transport messaging messaging patterns and protocols python_updates

Comments

@goodboy
Copy link
Owner

goodboy commented Jul 11, 2022 •
edited
Loading

In prep for #196, #311, and general use of py 3.10's match: syntax I think we should fully embrace msgspec as our primary interchange lib.

  • It's been tested thoroughly in production apps and performed great
  • we can't really move to a typed messaging model without having native support for msgspec.Struct

Dev/Release plan:

  • drop msgpack as part of our next alpha 0.1.0a5
  • refactor the ._ipc transport types and change the MsgpackTCPStream to be msgspec based.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
IPC and transport messaging messaging patterns and protocols python_updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop msgpack goodboy/tractor
1 participant
@goodboy