Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Run on multiple Images #297

Closed
wants to merge 2 commits into from
Closed

Fixes for Run on multiple Images #297

wants to merge 2 commits into from

Conversation

manojssmk
Copy link

This notebook demonstrates how to prompt multiple images and obtain a summary for each image in JSON format using threading.

Fix : #201

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:examples Issues/PR referencing examples folder labels Sep 26, 2024
@manojssmk manojssmk removed status:awaiting review PR awaiting review from a maintainer component:examples Issues/PR referencing examples folder labels Sep 26, 2024
@Giom-V Giom-V self-requested a review September 28, 2024 16:55
@Giom-V
Copy link
Collaborator

Giom-V commented Oct 2, 2024

Hello @manojssmk,

Thanks for the PR. I'll have a look in details this week and I'll likely add a couple of things, like a "what's next" section at the end (cf. template).

In the meantime, could you try to fix the lint issues? It's mainly changing all the "we"s into "you"s.

Thanks!

@markmcd markmcd added the status:awaiting response Awaiting a response from the author label Oct 18, 2024
@markmcd
Copy link
Member

markmcd commented Oct 18, 2024

A couple of quick drive-by comments from me:

  1. Please make sure you comply with the licenses when distributing third-party content (the images)
  2. Run pyink & nbfmt on the notebook to keep the code style-consistent
  3. I'm a little concerned that the code is "too smart" - does it need to demonstrate batching images into single prompts?
    • I would either put one image per request and a simple thread pool,
    • Or can you just put them all in one prompt? If performance is the point, then this is only 1 request, and it could show off the 2M context nicely.
    • Either way, it would help to understand what you are trying to demonstrate.

Copy link

github-actions bot commented Nov 1, 2024

Marking this pull request as stale since it has been open for 14 days with no activity. This PR will be closed if no further activity occurs.

@github-actions github-actions bot added the status:stale Issue/PR is marked for closure due to inactivity label Nov 1, 2024
Copy link

This pull request was closed because it has been inactive for 27 days. Please open a new pull request if you need further assistance. Thanks!

@github-actions github-actions bot closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:awaiting response Awaiting a response from the author status:stale Issue/PR is marked for closure due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run on Multiple Images
4 participants