-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DiscussService and TextService #512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status:awaiting review
PR awaiting review from a maintainer
component:python sdk
Issue/PR related to Python SDK
labels
Aug 19, 2024
MarkDaoust
requested changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can skip the markdown files and just regenerate those when the code is done.
MarkDaoust
requested changes
Aug 20, 2024
@@ -24,8 +24,8 @@ | |||
from google.generativeai.client import get_default_generative_async_client | |||
|
|||
from google.generativeai.types import helper_types | |||
from google.generativeai.types import text_types | |||
from google.generativeai.types import model_types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why move?
MarkDaoust
reviewed
Aug 22, 2024
MarkDaoust
approved these changes
Aug 22, 2024
The failing test is fixed by: #521 |
github-actions
bot
removed
the
status:awaiting review
PR awaiting review from a maintainer
label
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
We are deprecating the PaLM service, and in part, removing
DiscussService
andTextService
. This is also applies to theDiscussAsyncService
as well, and the associated clients.client.py
andtest_client.py
have been modified to reflect the changes as well.TextServiceClient
were removed fromanswer.py
.TextServiceClient
fromtest_client.py
.text_types.py
.