Async for files.py functions #586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status:awaiting review
MarkDaoust
requested changes
Oct 29, 2024
| @@ -97,6 +111,10 @@ def list_files(page_size=100) -> Iterable[file_types.File]: | |||
| yield file_types.File(proto) | |||
|
|
|||
|
|
|||
| async def list_files_async(*args, **kwargs): | |||
There was a problem hiding this comment.
I think this will fail because we want an async iterator to be returned here.
Can you copy the list_files code and add the missing asyncs?
| @@ -105,6 +123,10 @@ def get_file(name: str) -> file_types.File: | |||
| return file_types.File(client.get_file(name=name)) | |||
|
|
|||
|
|
|||
| async def get_file_async(*args, **kwargs): | |||
| return await asyncio.to_thread(get_file, *args, **kwargs) | |||
There was a problem hiding this comment.
We have an async client, we should use it. Let's copy-paste the code, and add the missing asyncs
| @@ -114,3 +136,7 @@ def delete_file(name: str | file_types.File | protos.File): | |||
| request = protos.DeleteFileRequest(name=name) | |||
| client = get_default_file_client() | |||
| client.delete_file(request=request) | |||
|
|
|||
|
|
|||
| async def delete_file_async(*args, **kwargs): | |||
| @@ -127,5 +130,29 @@ def test_files_delete(self): | |||
| # [END files_delete] | |||
|
|
|||
|
|
|||
| class AsyncTests(absltest.TestCase, unittest.IsolatedAsyncioTestCase): | |||
There was a problem hiding this comment.
We should test all the methods, I think list is broken right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
asynciomethods for all the file methods.However, how should we test these
asynciomethods?