You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Andrew, we support comparison on Numbers in C++ but organized in a different way. We convert all the Rvalues to be either flatFacts or Predicates. Some tests for reference:
OK I guess when constructing the ast, rather than making a separate AST node for RValue, you make a BaseFact where the name of the predicate is the operator here.
This might work OK for now, but eventually I think it's better to have a separate AST node for RValues since this way we are throwing away the information that this is a numeric comparison rather than a regular predicate. This might make the universe relation translation code slightly more awkward in one spot namely here, but I think we can work around it.
This was implemented for the rust version in #427 so this can follow that PR
The text was updated successfully, but these errors were encountered: