Fix skipShortTermRefPicSets in ts/H265Reader #11105
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR try to resolve issue androidx/media#303
The attached media file can be played by ffplay, but cause ExoPlayer throw exception during parse the SPS header from
skipShortTermRefPicSets
.skipShortTermRefPicSets
is a simplified version which only used for parse SPS. The full version see H.265/HEVC 7.3.7. and FFmpeg code and HM code .There are two bugs (or over-simplified) in the function
skipShortTermRefPicSets
, which cause this issue:use_delta_flag[j]
whenused_by_curr_pic_flag[j]
is 0.NumDeltaPocs
in each RefPicSet(RPS) maybe different,previousNumDeltaPocs
needs to be updated for predicted RPS too.Although each RPS always predict from previous one, but the number of deltaPocs of current RPS depends on the values of
use_delta_flag[j]
andused_by_curr_pic_flag[j]
. CurrentlypreviousNumDeltaPocs
only updated for non-predicted RPS.