Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore doesn't work without equals sign #107

Open
makandre opened this issue Apr 18, 2022 · 2 comments
Open

Ignore doesn't work without equals sign #107

makandre opened this issue Apr 18, 2022 · 2 comments

Comments

@makandre
Copy link

I'm using the addlicense container like so:

$ podman run --rm -v $PWD:/src ghcr.io/google/addlicense -v -check -ignore node_modules/** .

But this doesn't skip node_modules directory. However, if I changed it to -ignore=node_modules/**, then it skips node_modules as expected.

If this isn't a bug then it should be made clear in the readme that = is required

@willnorris
Copy link
Collaborator

My guess is that your shell is interpreting the "**" before it gets passed to addlicense. What happens if you put it in quotes?

$ podman run --rm -v $PWD:/src ghcr.io/google/addlicense -v -check -ignore "node_modules/**" .

Assuming that works, this is pretty normal and expected, but probably worth a mention in the docs as you say.

@makandre
Copy link
Author

Thanks for the quick reply. Yes you are right, putting in quotes works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants