Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support general comment blocks in addition to line comments #34

Open
shomron opened this issue Mar 9, 2020 · 1 comment
Open

Support general comment blocks in addition to line comments #34

shomron opened this issue Mar 9, 2020 · 1 comment

Comments

@shomron
Copy link

shomron commented Mar 9, 2020

The tool only supports line comments at this time. Additionally, it will not detect existing general comment blocks, causing duplication where these have been used.

Example diff:

+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
 /*

 Licensed under the Apache License, Version 2.0 (the "License");
@willnorris
Copy link
Collaborator

Is it line versus block comments that is causing the duplication, or rather the fact that the existing license comment isn't being detected by the current hasLicense logic, which is looking for (among a few other things) a Copyright line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants