Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation is not compatible with jdk8 #58

Open
ShibasishDelphix opened this issue Jul 19, 2024 · 1 comment
Open

Instrumentation is not compatible with jdk8 #58

ShibasishDelphix opened this issue Jul 19, 2024 · 1 comment

Comments

@ShibasishDelphix
Copy link

Hi Team,
We upgraded java-allocation-instrumenter from 3.0 to 3.4.0. We use AdoptOpenJdk1.8. Post upgrade
AllocationRecorder.getInstrumentation() in ConstructorInstrumenter is being returned as null. The same was earlier getting mapped to sun.instrument.InstrumentationImpl in v3.0.
Could you please confirm if 3.4.0 is compatible with jdk1.8 and help me.
Thanks.

@cpovirk
Copy link
Member

cpovirk commented Jul 19, 2024

As far as I know, we still support it: The tests pass with --java_runtime_version=8, and I don't see anything in the release notes about dropping support. (We did document dropping support for Java 7 in 3.3.1, and I don't see anything similar about Java 8.) But Google is on JDK 11+ at this point, so JDK8 isn't getting any real-world testing from us anymore. It's entirely possible that support has regressed. This project doesn't get much attention in general nowadays, so I don't know how likely it is that we'd look into this even if we had a way to reproduce it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants