Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not be able to enable if-return block outside of procedure definition #1392

Closed
1 of 2 tasks
vicng opened this issue Oct 26, 2017 · 2 comments
Closed
1 of 2 tasks
Assignees
Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong low priority

Comments

@vicng
Copy link
Contributor

vicng commented Oct 26, 2017

Problem statement

  • Bug report
  • Feature request

The "Enable block" context menu option should be disabled when the if-return block is not connected to a procedure definition block.

Steps to Reproduce

  1. Add if-return block to workspace
  2. Right-click the block. The "Enable block" option is selectable.
@vicng vicng added the issue: bug Describes why the code or behaviour is wrong label Oct 26, 2017
@samelhusseini
Copy link
Contributor

More or less the same as #1390.

I think for this we should add a canBeDisabled property on a Blockly.Block, and only show the context menu if that property is true. The procedures_if_return block should set canBeDisabled to false.

@samelhusseini samelhusseini added help wanted External contributions actively solicited low priority labels Jan 16, 2020
@johnnesky johnnesky self-assigned this Mar 23, 2024
@johnnesky johnnesky mentioned this issue Mar 23, 2024
1 task
@johnnesky
Copy link
Member

Fixed by: #7958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong low priority
Projects
None yet
Development

No branches or pull requests

3 participants