Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an API to programmatically scroll the workspace #7176

Closed
1 task done
BeksOmega opened this issue Jun 16, 2023 · 5 comments · Fixed by #7532
Closed
1 task done

Add an API to programmatically scroll the workspace #7176

BeksOmega opened this issue Jun 16, 2023 · 5 comments · Fixed by #7532
Assignees
Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ good first issue issue: feature request Describes a new feature and why it should be added size: small Bugs that can be picked up and completed in 1-3 days

Comments

@BeksOmega
Copy link
Collaborator

BeksOmega commented Jun 16, 2023

🚧⚠️🚧 This issue is being saved for Grace Hopper Open Source Day. 🚧⚠️🚧 An event we're running to help girls and non-binary technologists make their first contributions to open source! Please see our list of help wanted issues if you'd like to contribute!


Check for duplicates

  • I have searched for similar issues before opening a new one.

Problem

Sometimes you want to change how your users interact with scrolling the workspace. E.g. if you have a workspace that only supports vertical scrolling or only supports horizontal scrolling, you may want to add buttons that scroll instead of using the scrollbars.

Context: https://groups.google.com/g/blockly/c/klLbJ1aQqsA/m/lYjP5tyAAgAJ

Request

Add an API for programatically scrolling the workspace. I'm not sure what the units should be (absolute vs relative, percentage vs workspace units, etc).

Alternatives considered

No response

Additional context

We currently have a scroll method on the workspace, but it is marked as @internal:

scroll(x: number, y: number) {

To Fix

  1. Remove the @internal tag from the scroll method.
@BeksOmega BeksOmega added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member labels Jun 16, 2023
@maribethb
Copy link
Contributor

Seems reasonable to make the scroll function public. We just need to remove the @internal tag from the documentation comment.

@maribethb maribethb added good first issue and removed issue: triage Issues awaiting triage by a Blockly team member labels Jun 21, 2023
@carthick
Copy link

Could you please assign me this issue.

@maribethb
Copy link
Contributor

Hi @carthick, I've assigned you the issue. You can find some information about how to contribute to Blockly here. Thanks for your interest!

@BeksOmega BeksOmega added the ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ label Sep 5, 2023
@BeksOmega BeksOmega moved this to Needs Detail in Blockly GHC OSD Sep 5, 2023
@BeksOmega BeksOmega added the size: small Bugs that can be picked up and completed in 1-3 days label Sep 5, 2023
@BeksOmega BeksOmega moved this from Needs Detail to Ready for Work in Blockly GHC OSD Sep 6, 2023
@SophieNguyen113
Copy link
Contributor

I would love to work on this issue

@BeksOmega
Copy link
Collaborator Author

@SophieNguyen113 Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ good first issue issue: feature request Describes a new feature and why it should be added size: small Bugs that can be picked up and completed in 1-3 days
Projects
No open projects
Status: Done Testing
Development

Successfully merging a pull request may close this issue.

4 participants