Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated browser tests reference broken or missing categories #8132

Closed
1 of 3 tasks
rachel-fenichel opened this issue May 16, 2024 · 1 comment
Closed
1 of 3 tasks
Assignees
Labels
issue: bug Describes why the code or behaviour is wrong

Comments

@rachel-fenichel
Copy link
Collaborator

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

The automated browser tests open all of the categories in the toolbox and drag out each block.

  • There's a hard-coded list of basic categories in tests/browser/test/toolbox_drag_test.js, and it includes Colour. This category and the associated blocks have been removed from core and need to be removed from this test.
  • There's a hard-coded list of test categories in the same file, including Validators. This fails because some of the validator blocks referred to now-removed fields. This has been fixed in the most recent version of dev-tools, so the solution is to update the dependency and then verify that the validators category works again.

Reproduction steps

Stack trace

No response

Screenshots

No response

Browsers

No response

@rachel-fenichel rachel-fenichel added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member and removed issue: triage Issues awaiting triage by a Blockly team member labels May 16, 2024
@johnnesky johnnesky self-assigned this Aug 2, 2024
@johnnesky
Copy link
Member

I addressed the problems described above, but created #8466 to track another problem I discovered in this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

No branches or pull requests

2 participants