Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a blocklyNumberField CSS class to number fields #8313

Closed
BeksOmega opened this issue Jul 11, 2024 · 7 comments · Fixed by #8414
Closed

Add a blocklyNumberField CSS class to number fields #8313

BeksOmega opened this issue Jul 11, 2024 · 7 comments · Fixed by #8414
Assignees
@Apocalypse96
Labels
good first issue help wanted External contributions actively solicited PR: feature Adds a feature
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

In the FieldNumber class override the initView method to call dom.addClass with the this.fieldGroup_ and 'blocklyNumberField'. You will need to add import * as dom from './utils/dom.js'; to call dom.addClass.

This change should be made against the rc/v12.0.0 branch.

To work on this issue, comment below asking to be assigned.
@BeksOmega BeksOmega added help wanted External contributions actively solicited PR: feature Adds a feature good first issue labels Jul 11, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 11, 2024
@ruthwikchikoti
Copy link

@BeksOmega, please assign this to me. I'm eager to work on it.

@BeksOmega
Copy link
Collaborator Author

Go for it @ruthwikchikoti ! Let me know if you have any questions =)

@Apocalypse96
Copy link

Hey @ruthwikchikoti Can you pls give me a chance to solve this issue

@ruthwikchikoti
Copy link

@Apocalypse96 sure

@ruthwikchikoti ruthwikchikoti removed their assignment Jul 22, 2024
@Apocalypse96
Copy link

Apocalypse96 commented Jul 22, 2024 •
edited
Loading

Hey @BeksOmega can you please review my PR #8414

@sachan13harshit
Copy link

@BeksOmega can you pls assign it to me?

@Apocalypse96 Apocalypse96 mentioned this issue Jul 22, 2024
Closed
1 task
Apocalypse96 added a commit to Apocalypse96/blockly that referenced this issue Jul 22, 2024
@Apocalypse96
feat: Add a blocklyNumberField CSS class to number fields google#8313
589983e
@Apocalypse96 Apocalypse96 mentioned this issue Jul 22, 2024
Merged
1 task
Apocalypse96 added a commit to Apocalypse96/blockly that referenced this issue Jul 23, 2024
@Apocalypse96
feat: add 'blocklyNumberField' CSS class to FieldNumber Fixes google#…
5d7f63d 
…8313
Apocalypse96 added a commit to Apocalypse96/blockly that referenced this issue Jul 31, 2024
@Apocalypse96
feat: Add a blocklyNumberField CSS class to number fields google#8313
0ff7bbd
Apocalypse96 added a commit to Apocalypse96/blockly that referenced this issue Jul 31, 2024
@Apocalypse96
feat: add 'blocklyNumberField' CSS class to FieldNumber Fixes google#…
ed4c9f0 
…8313
BeksOmega pushed a commit that referenced this issue Jul 31, 2024
@Apocalypse96
feat: Add a blocklyNumberField CSS class to number fields (#8414)
8a1b015 
* feat: Add a blocklyNumberField CSS class to number fields #8313

* feat: add 'blocklyNumberField' CSS class to FieldNumber Fixes #8313
@BeksOmega
Copy link
Collaborator Author

Closed by #8414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Apocalypse96 Apocalypse96

Labels
good first issue help wanted External contributions actively solicited PR: feature Adds a feature
Projects
None yet
Milestone
v12
Development

Successfully merging a pull request may close this issue.

feat: Add a blocklyNumberField CSS class to number fields Apocalypse96/blockly
4 participants
@BeksOmega @sachan13harshit @Apocalypse96 @ruthwikchikoti