Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a blocklyImageField CSS class to image fields #8314

Closed
BeksOmega opened this issue Jul 11, 2024 · 3 comments
Closed

Add a blocklyImageField CSS class to image fields #8314

BeksOmega opened this issue Jul 11, 2024 · 3 comments
Assignees
@vexora-0
Labels
help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added size: small Bugs that can be picked up and completed in 1-3 days
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

In the FieldImage class modify the initView method to call dom.addClass with the this.fieldGroup_ and 'blocklyImageField'.

This change should be made against the rc/v12.0.0 branch.

To work on this issue, comment below asking to be assigned.
@BeksOmega BeksOmega added help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added good first issue labels Jul 11, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 11, 2024
@vexora-0
Copy link

i want to work on this

@BeksOmega
Copy link
Collaborator Author

Go for it @vexora-0 =) Let me know if you have any questions!

@vexora-0 vexora-0 mentioned this issue Jul 16, 2024
Closed
1 task
@vexora-0
Copy link

hey @BeksOmega can you check my pr

This was referenced Jul 24, 2024
Closed
Closed
vexora-0 added a commit to vexora-0/blockly that referenced this issue Jul 28, 2024
@vexora-0
feat: Added blocklyImageField CSS class to image fields google#8314
09073b9
@vexora-0 vexora-0 mentioned this issue Jul 28, 2024
Merged
BeksOmega pushed a commit that referenced this issue Jul 30, 2024
@vexora-0
feat: Added blocklyImageField CSS class to image fields #8314 (#8439)
4b95cb7
@BeksOmega BeksOmega added size: small Bugs that can be picked up and completed in 1-3 days and removed good first issue labels Aug 13, 2024
@gonfunko gonfunko closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vexora-0 vexora-0

Labels
help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added size: small Bugs that can be picked up and completed in 1-3 days
Projects
None yet
Milestone
v12
Development

Successfully merging a pull request may close this issue.

feat: add blocklyImageField CSS class to image fields
3 participants
@gonfunko @BeksOmega @vexora-0