Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the InsertionMarkerManager #8353

Closed
BeksOmega opened this issue Jul 12, 2024 · 9 comments
Closed

Delete the InsertionMarkerManager #8353

BeksOmega opened this issue Jul 12, 2024 · 9 comments
Assignees
Milestone

Comments

@BeksOmega
Copy link
Collaborator

We should delete the InsertionMarkerManager and any remaining references to it. There may be some complications where it hooks into the renderer that mean we have to keep some enums.

@BeksOmega BeksOmega added this to the v12 milestone Jul 12, 2024
@ChaitanyaYeole02
Copy link

Hey. Can you assign the issue to me please?

@BeksOmega
Copy link
Collaborator Author

Go for it @ChaitanyaYeole02 =) Let me know if you have any questions!

@BeksOmega
Copy link
Collaborator Author

Ah actually @ChaitanyaYeole02 I didn't realize this wasn't a good-first-issue when I assigned it. Might be better to start with something like #8342 instead =)

@ChaitanyaYeole02
Copy link

Ok sure, I will work on #8342 instead.

@ChaitanyaYeole02
Copy link

Hey @BeksOmega, I have done two good first issues. I am not able to find any more available right now. Do you think, that I could work on this right now?

@BeksOmega
Copy link
Collaborator Author

Sounds good! But like the issue warns, there might be some trickiness. Let me know if you have any questions =)

@ChaitanyaYeole02
Copy link

ChaitanyaYeole02 commented Jul 20, 2024

@BeksOmega, what will be the type of this issue?
I think this is a chore, but can you please confirm this?

https://developers.google.com/blockly/guides/contribute/get-started/commits

I am referring this.

@BeksOmega
Copy link
Collaborator Author

@BeksOmega, what will be the type of this issue? I think this is a chore, but can you please confirm this?

https://developers.google.com/blockly/guides/contribute/get-started/commits

I am referring this.

Yes chore is correct!

@ashmichheda
Copy link

@BeksOmega - Is this issue still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants