-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RenderedWorkspaceComments setDeleteStyle not working #8413
Comments
Hey @BeksOmega: can you add a description of what needs to be fixed here and then remove the triage label? Thanks! |
Hey @BeksOmega : I want to work on this issue...could you please assign this issue to me !! |
Hi, I was also looking into this issue today. I narrowed it down to: e4b734c Deleting However, I don't know what problem this commit was trying to solve, and it's not clear from looking at the commit description why it was necessary. |
Aha I think I figured it out. The style added 2 months ago in e4b734c was necessary at the time because there wasn't any other style at the time that provided the drag cursor. However, 4cdca28 was added 2 weeks ago and provides the drag cursor for the parent element along with the necessary variations, making the previous commit obsolete. |
@srivastavaarpit977, I've assigned the issue to you. It looks like the solution is straightforward, see my comments. We just need to revert e4b734c |
Check for duplicates
Description
Currently, the visual style of the cursor to show that whatever comment it is dragging is going to be deleted when hovering over the trash can is not showing up.
Multiselect Plugin context: It only works for blocks even though I am calling the setDeleteStyle(true) for each of the subdraggables. I also checked whether the comment was deletable, which was true, so I am not sure why the visual style is not being updated.
Beka has already told me that this is a CSS bug.
Reproduction steps
Stack trace
No response
Screenshots
No response
Browsers
No response
The text was updated successfully, but these errors were encountered: