Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderedWorkspaceComments setDeleteStyle not working #8413

Closed
1 task done
changminbark opened this issue Jul 22, 2024 · 5 comments · Fixed by #8477
Closed
1 task done

RenderedWorkspaceComments setDeleteStyle not working #8413

changminbark opened this issue Jul 22, 2024 · 5 comments · Fixed by #8477
Assignees
Labels
issue: bug Describes why the code or behaviour is wrong

Comments

@changminbark
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

Currently, the visual style of the cursor to show that whatever comment it is dragging is going to be deleted when hovering over the trash can is not showing up.

Multiselect Plugin context: It only works for blocks even though I am calling the setDeleteStyle(true) for each of the subdraggables. I also checked whether the comment was deletable, which was true, so I am not sure why the visual style is not being updated.
image

Beka has already told me that this is a CSS bug.

Reproduction steps

Stack trace

No response

Screenshots

No response

Browsers

No response

@changminbark changminbark added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Jul 22, 2024
@cpcallen
Copy link
Contributor

Hey @BeksOmega: can you add a description of what needs to be fixed here and then remove the triage label? Thanks!

@srivastavaarpit977
Copy link

Hey @BeksOmega : I want to work on this issue...could you please assign this issue to me !!

@johnnesky
Copy link
Member

Hi, I was also looking into this issue today. I narrowed it down to: e4b734c

Deleting cursor: grab; from this style fixes the above issue in my local testing. A parent element has the .blocklyDraggable CSS class which provides the same cursor, but the parent element does a better job of switching the cursor (to a closed fist when the mouse is pressed, and a hand with a red X when hovering over the trashcan).

However, I don't know what problem this commit was trying to solve, and it's not clear from looking at the commit description why it was necessary.

@johnnesky
Copy link
Member

Aha I think I figured it out. The style added 2 months ago in e4b734c was necessary at the time because there wasn't any other style at the time that provided the drag cursor. However, 4cdca28 was added 2 weeks ago and provides the drag cursor for the parent element along with the necessary variations, making the previous commit obsolete.

@johnnesky
Copy link
Member

@srivastavaarpit977, I've assigned the issue to you. It looks like the solution is straightforward, see my comments. We just need to revert e4b734c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants