Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate variables are shown in flyout while procedure mutator field is being edited #8693

Open
1 task done
gonfunko opened this issue Dec 10, 2024 · 1 comment
Open
1 task done
Labels
issue: bug Describes why the code or behaviour is wrong

Comments

@gonfunko
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

If you add an input to a procedure and rename it, the variables category in the flyout will display variables for each keystroke until the input field in the mutator bubble loses focus, at which point the intermediate variables disappear and only the variable corresponding to the input's final name remains.

Reproduction steps

  1. Drag out a procedure block
  2. Open its mutator
  3. Add a new input
  4. Rename the input
  5. While the input name field still has focus in the mutator bubble, open the Variables category of the toolbox
  6. Observe that variables corresponding to each keystroke are present
  7. Click outside of the input name field in the mutator bubble to cause it to lose focus
  8. Reopen the Variables category, and observe that the intermediate state variables are gone, leaving only one corresponding to the final name of the input

Stack trace

Screenshots

Image

Browsers

No response

@gonfunko gonfunko added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Dec 10, 2024
@cpcallen
Copy link
Contributor

When checking any fix for this, do test (or better still: add tests) to see what happens if one of the intermediate variable names clashes with another variable/parameter—e.g., if there is a variable foo and you rename a parameter from f to food.

@cpcallen cpcallen removed the issue: triage Issues awaiting triage by a Blockly team member label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

No branches or pull requests

2 participants