feat!: bubble ownership #7071
Merged
feat!: bubble ownership #7071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
reviewed
May 10, 2023
BeksOmega
force-pushed
the
feat/bubble-ownership
branch
from
7479ba5 to
e284cea
Compare
maribethb
approved these changes
May 11, 2023
BeksOmega
force-pushed
the
feat/bubble-ownership
branch
from
4296d87 to
64463c0
Compare
github-actions
bot
added
breaking change
github-actions
bot
added
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7061
Proposed Changes
Refactors the bubble so that it owns its own view elements, instead of being passed them in the constructor.
Reason for Changes
Clear separation between models and views.
Test Coverage
N/A
Documentation
N/A
Additional Information
Things may have to change as I subclass this to create the bubble subclasses, but I think this is basically gtg!
Breaking changes / updating / upgrading
This change is unlikely to affect you unless you are monkey patching Blockly to support custom icons. In this case, we recommend checking out the docs for creating custom bubbles, and bringing your implementation back to mainline based on those =)
If you were using the
Blockly.Bubbleclass it is now located atBlockly.bubbles.Bubble. The blockly migration script can automatically perform this rename for you.