fix: have inputs construct connections #7116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
May 24, 2023
core/inputs/input.ts
Outdated
| @@ -298,6 +293,10 @@ export class Input { | |||
| this.connection.dispose(); | |||
| } | |||
| } | |||
|
|
|||
| protected makeConnection(type: number): Connection { | |||
There was a problem hiding this comment.
Just curious, why isn't the type of type ConnectionType?
There was a problem hiding this comment.
upon rereading this sentence: @_@
There was a problem hiding this comment.
Fixed!
On the block version of this method we used to pass inputTypes to it sometimes, which isn't compatible with ConnectionType, so we had to use number instead. But since the code has been reorganized, that is no longer an issue =) Everything has been switched to use ConnectionType!
BeksOmega
requested review from
maribethb
and removed request for
rachel-fenichel
maribethb
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #2062
Proposed Changes
Makes it so that inputs must + can easily construct their own connections (for inputs that have connections).
Behavior Before Change
Inputs were passed their connections, except for custom inputs which weren't. It was difficult for custom inputs to construct their own connections, because they had to deal with rendered vs headless.
Behavior After Change
All inputs must construct their own connections. They can easily do this using the
protected makeConnectionmethod.Reason for Changes
This makes built-in inputs and custom inputs more consistent. It also makes custom inputs with connections easier to implement.
Test Coverage
N/A
Documentation
N/A
Additional Information
N/A