feat: use new intermediate block change event for field edits, normal block change event for closing editor. #7105 #7151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ield_intermediate_change.ts
BeksOmega
approved these changes
Jun 13, 2023
core/field_angle.ts
Outdated
There was a problem hiding this comment.
Can you add this change in samples as well? Since we're migrating the angle field over there (we're leaving it in both places for a month or two to give people time to transition).
If not I can grab this since I'm testing samples this quarter anyway =)
There was a problem hiding this comment.
Probably not until this is committed and blockly-samples depends on the latest version, but I created an issue to do so: google/blockly-samples#1717
BeksOmega
approved these changes
Jun 16, 2023
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another proposal to fix #2496. Creates a new event type specifically for intermediate field value changes, which is not recorded in undo history. Inhibits firing normal block change events for field value edits when triggered via a user input widget, and instead broadcasts this new event type. When the input widget is disposed, then a standard block change event will be fired with an oldValue corresponding to what the field's value was when the widget was opened.
Compare with: #7064 and #7105
Unlike #7105 this version of the new event type inherits from BlockBase instead of UiBase. The difference is minor and only affects one file: events_block_field_intermediate_change.ts