fix: icon exports #7159
Merged
fix: icon exports #7159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
commented
Jun 13, 2023
scripts/migration/renamings.json5
Outdated
Comment on lines
1481
to
1484
| { | ||
| oldName: 'Blockly.Icon', | ||
| newName: 'Blockly.icons.Icon', | ||
| } |
There was a problem hiding this comment.
@cpcallen I think this is correct, b/c the export didn't get renamed, but if you could verify that would be appreciated!
There was a problem hiding this comment.
There doesn't seem to be a goog.module ID for this module, so strictly speaking there's not a correct way to represent this in the renamings file as it is presently structured, but this will have the desired effect.
BeksOmega
force-pushed
the
chore/icon-exports
branch
from
053394f to
806c7a6
Compare
maribethb
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #2105
Fixes #7082
Proposed Changes
Makes sure that we are exporting the correct icon-related things.
Reason for Changes
Exporting things is like our whole job :P
Test Coverage
N/A
Documentation
N/A
Additional Information
I updated #7060 to be a breaking change, and added docs about upgrading there.