Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly pass the block to the icon constructor in blockfactory blocks #7202

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes N/A

Proposed Changes

Properly passes the block to the mutator icon constructor in the block factory demos.

Behavior Before Change

The block factory field blocks would cause console errors.

Behavior After Change

No Errors

Reason for Changes

The block factory should be usable!

Test Coverage

N/A

Documentation

Going to update the description of the mutator refactor PR to include info about needing to pass the block to the constructor. Previously passing the block was optional (even though it was not marked as optional).

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner June 23, 2023 17:50
@BeksOmega BeksOmega requested a review from maribethb June 23, 2023 17:50
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jun 23, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@github-actions github-actions bot added the PR: fix Fixes a bug label Jun 23, 2023
@BeksOmega BeksOmega force-pushed the fix/block-factory-fields branch from 3c21a30 to b20e066 Compare June 23, 2023 17:57
@BeksOmega BeksOmega merged commit acbe2c6 into google:develop Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants