fix: prevent flyout block highlighting during workspace drag #7720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
neerajkumarc
force-pushed
the
fix/flyout-highlight-on-drag
branch
from
d679620 to
504a6c5
Compare
|
Hiya @neerajkumarc can you coment on #1801 so I can assign you? |
BeksOmega
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
This looks great =) Thank you for the fix @neerajkumarc ! Just going to wait for CI to run then I'll get this merged =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #1801
Proposed Changes
Fixes issue where flyout blocks were incorrectly highlighted during workspace drag,
by adding a check for the workspace's drag state before triggering block highlighting events.
Reason for Changes
Flyout blocks should not highlight if the workspace is being dragged.
Test Coverage
N/A
Documentation
N/A
Additional Information
N/A