Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional test to short-circuit #1076

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

TristonianJones
Copy link
Collaborator

List, map, and struct creations will short-circuit the optional element codepaths
if it is determined during planning that these literals do not contain optional
elements. The code is functional, but hasOptionals was trivially false due
to a bug in the planning code. This has been corrected.

@TristonianJones TristonianJones merged commit ff1302f into google:master Nov 21, 2024
2 checks passed
@renovate renovate bot mentioned this pull request Dec 2, 2024
1 task
@renovate renovate bot mentioned this pull request Dec 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants