Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Extend HTTP probe type to add support for OAuth-authenticated probes #27

Closed
manugarg opened this issue Aug 17, 2017 · 7 comments
Closed
Assignees
Milestone

Comments

@manugarg
Copy link
Contributor

No description provided.

@p-singh
Copy link

p-singh commented Jun 10, 2019

@manugarg I would like to contribute to this feature. Could you let me know what initial ideas you have in mind and some pointers to start and I shall take it up from there?

@manugarg
Copy link
Contributor Author

@p-singh That's great. I actually didn't give much thought to the implementation, but thinking about it now, it seems like main challenge is going to be abstracting out various credential formats. I am most familiar with Google style credentials and for those, first step could simply be supporting Application Default Credentials:
https://cloud.google.com/docs/authentication/production#providing_credentials_to_your_application

What use case did you have in mind for this feature. Understanding that could be useful in planning this further.

@manugarg
Copy link
Contributor Author

manugarg commented Dec 7, 2019

@manugarg manugarg self-assigned this Dec 10, 2019
@manugarg
Copy link
Contributor Author

Assigning to myself as I have started working on it.

@manugarg manugarg added this to the v0.10.7 milestone Dec 10, 2019
@manugarg
Copy link
Contributor Author

2410e7e added OAuth support for HTTP probe.

@manugarg
Copy link
Contributor Author

manugarg commented Jan 4, 2020

Support for JWT as web token: 0ee300c

Next up, I'll be adding support for reading JSON key file (and other files) from GCS.

@manugarg
Copy link
Contributor Author

This is now available in the v0.10.7 release:
https://github.com/google/cloudprober/releases/tag/v0.10.7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants